build 0.19b2 #53

amueller · 2017-07-19T20:28:01Z

cc @ogrisel

Configure master NumPy 1.10 builds

Configure master NumPy 1.11 builds

* 0.18 version bump * use git tag instead of pipy * fix hash, move to sha256

…render_master MNT: Re-render the feedstock [ci skip]

…render_master_np1.10 MNT: Re-render the feedstock [ci skip]

….10_1.4.6 MNT: Re-rendered with conda-smithy 1.4.6 [ci skip]

MNT: Re-rendered with conda-smithy 1.4.6 [ci skip]

…rsion_pin_master MNT: Update pinned versions.

…rsion_pin_master_np1.10 MNT: Update pinned versions.

…1.10__1.7.0 MNT: Re-rendered with conda-smithy 1.7.0 [ci skip]

….7.0 MNT: Re-rendered with conda-smithy 1.7.0 [ci skip]

numpy 1.12 and python 3.6 support

MNT: Re-rendered with conda-smithy 2.0.1

Update maintainers [ci skip]

amueller · 2017-07-19T20:33:46Z

this is copied from master basically. It looks like it's only building one numpy version. Is that the standard?

jakirkham · 2017-07-19T21:20:15Z

circle.yml

@@ -1,6 +1,6 @@
 checkout:
  post:
-    - ./ci_support/checkout_merge_commit.sh
+    - ./ci_support/fast_finish_ci_pr_build.sh


Weird that we are losing checkout_merge_commit.sh. Could you please try re-rendering again?

jakirkham · 2017-07-19T21:22:56Z

Not going to have lots of time to look at this near term as I'm buried with other work.

It looks like it's only building one numpy version. Is that the standard?

If you recall, we had to create separate branches for each NumPy version because of the time limits with CircleCI. ( #52 ) So we will likely need to do the same thing with the rc branch.

amueller · 2017-07-19T21:39:07Z

oh, right...

amueller · 2017-07-19T21:48:53Z

rerendered

jakirkham · 2017-07-19T21:53:08Z

Looks better. Thanks.

Yeah, we should have a better solution for the NumPy matrix once PR ( conda-forge/conda-smithy#532 ) is merged. Though there has been some discussion about doing NumPy pinning totally differently, which could also help if it works well. ( conda-forge/pandas-feedstock#32 ) Could try the different pinning in this release as well if you would like.

jakirkham · 2017-07-19T22:10:49Z

Actually ignore the pandas suggestion as it doesn't work here due to blas support. We would need to go to multiple branches.

amueller · 2017-07-20T18:34:39Z

So merge this and then do multiple branches for the different numpy releases?

jakirkham · 2017-07-20T19:18:48Z

We can do that. While this is a bit unorthodox, I'm kind of want to re-rendering with the development version of conda-smithy to get CircleCI matrix support to see how that goes. Thoughts?

amueller · 2017-07-20T20:44:31Z

yeah sure, go for it.

Re-renders with a dev version of `conda-smithy`, which provides support for build matrices in CircleCI. While this feature has had some testing, it has not gone live yet and should not generally be used until it is released.

Re-renders with a dev version of `conda-smithy`, which provides support for build matrices in CircleCI. While this feature has had some testing, it has not gone live yet and should not generally be used until it is released. Adds in the other NumPy versions to CircleCI and Travis CI matrices.

jakirkham · 2017-07-20T21:09:55Z

Done. Unfortunately CircleCI puts each build in a separate status. That said, it is tolerable given we actually get a build matrix. :)

jakirkham · 2017-07-23T18:20:39Z

There seems to be a compilation error. Thoughts?

Error compiling Cython file:
------------------------------------------------------------
...

    cdef inline DTYPE_t dist(self, DTYPE_t* x1, DTYPE_t* x2,
                             ITYPE_t size) except -1 with gil:
        cdef np.ndarray x1arr
        cdef np.ndarray x2arr
        with gil:
            ^
------------------------------------------------------------

ogrisel · 2017-07-24T07:24:00Z

Indeed a change in cython 0.26 makes this construct invalid. This has been fixed in master and needs to be backported to the 0.19.X branch. Would it be possible to build 0.19b2 with Cython 0.25.2 in the mean time? It's just a build dependency, scikit-learn does not need cython at runtime.

jakirkham · 2017-07-24T13:26:13Z

Sorry fixed in which master? scikit-learn or cython?

In either case, pinning cython to an older version is perfectly acceptable.

amueller · 2017-07-24T14:58:33Z

Fixed in scikit-learn master.

Re-render with a development copy of conda-smithy to add matrix support.

jakirkham · 2017-07-24T16:28:16Z

Thanks for the info. Have re-rendered with development version of conda-smithy again to get the matrix back. I don't think there will be any need for further re-renderings, but we can discuss if needed.

amueller · 2017-07-24T16:31:33Z

Thanks :) Sent from phone. Please excuse spelling and brevity.

…

On Jul 24, 2017 12:28 PM, "jakirkham" ***@***.***> wrote: Thanks for the info. Have re-rendered with development version of conda-smithy again to get the matrix back. I don't think there will be any need for further re-renderings, but we can discuss if needed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#53 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAbcFmA8oVTNEYgfZXyxq4SLA9by1Wy_ks5sRMYhgaJpZM4OdQSU> .

ogrisel · 2017-07-25T07:46:49Z

LGTM.

I backported the GIL fix in the scikit-learn 0.19.X branch so that 0.19 final won't have this problem anymore.

jakirkham and others added 30 commits September 27, 2016 16:40

recipe: Restrict to NumPy 1.10.x only.

95e8716

Re-render with conda-smithy version 1.2.0.

1e7dbd9

recipe: Restrict to NumPy 1.11.x only.

677c623

Re-render with conda-smithy version 1.2.0.

4ea44bd

Merge pull request conda-forge#12 from jakirkham/config_master_np1.10

d9ac189

Configure master NumPy 1.10 builds

Merge pull request conda-forge#13 from jakirkham/config_master_np1.11

ccd3400

Configure master NumPy 1.11 builds

Release0.18 np1.10 (conda-forge#17)

35397b6

* 0.18 version bump * use git tag instead of pipy * fix hash, move to sha256

Release 0.18 (conda-forge#11)

f53d9ef

* 0.18 version bump * use git tag instead of pipy * fix hash, move to sha256

MNT: Updated the feedstock for conda-smithy version 1.3.2.

c6b5f24

MNT: Updated the feedstock for conda-smithy version 1.3.2.

220f980

Merge pull request conda-forge#18 from conda-forge-admin/feedstock_re…

66af77e

…render_master MNT: Re-render the feedstock [ci skip]

Merge pull request conda-forge#19 from conda-forge-admin/feedstock_re…

bebd406

…render_master_np1.10 MNT: Re-render the feedstock [ci skip]

MNT: Re-rendered with conda-smithy 1.4.6

6c7ae29

MNT: Re-rendered with conda-smithy 1.4.6

4fce354

Merge pull request conda-forge#22 from jakirkham/re-render_master_np1…

fcf32aa

….10_1.4.6 MNT: Re-rendered with conda-smithy 1.4.6 [ci skip]

Merge pull request conda-forge#21 from jakirkham/re-render_master_1.4.6

d32bfd2

MNT: Re-rendered with conda-smithy 1.4.6 [ci skip]

MNT: Updated some of the pinned versions

465208a

MNT: Updated some of the pinned versions

dbd572e

Merge pull request conda-forge#25 from conda-forge-admin/feedstock_ve…

5c64c22

…rsion_pin_master MNT: Update pinned versions.

Merge pull request conda-forge#26 from conda-forge-admin/feedstock_ve…

8a80b23

…rsion_pin_master_np1.10 MNT: Update pinned versions.

MNT: Re-rendered with conda-smithy 1.7.0

6a21804

MNT: Re-rendered with conda-smithy 1.7.0

296d01f

Merge pull request conda-forge#29 from jakirkham/re-render__master_np…

2fe9fdd

…1.10__1.7.0 MNT: Re-rendered with conda-smithy 1.7.0 [ci skip]

Merge pull request conda-forge#30 from jakirkham/re-render__master__1…

90067bb

….7.0 MNT: Re-rendered with conda-smithy 1.7.0 [ci skip]

MNT: Re-rendered with conda-smithy 2.0.0

d2a0fc3

Merge pull request conda-forge#33 from astaric/numpy-1.12

c827326

numpy 1.12 and python 3.6 support

Update maintainers

a42593d

MNT: Re-rendered with conda-smithy 2.0.1

93560e6

Merge pull request conda-forge#37 from astaric/np112-py36

ac7eb2f

MNT: Re-rendered with conda-smithy 2.0.1

Merge pull request conda-forge#36 from astaric/update-maintainers

c6d0b95

Update maintainers [ci skip]

remove unused patch

0d1cac1

jakirkham reviewed Jul 19, 2017

View reviewed changes

MNT: Re-rendered with conda-smithy 2.3.2

308dc4b

jakirkham added 3 commits July 20, 2017 17:05

MNT: Re-rendered with conda-smithy 2.3.2.post.dev52

9ce6698

Re-renders with a dev version of `conda-smithy`, which provides support for build matrices in CircleCI. While this feature has had some testing, it has not gone live yet and should not generally be used until it is released.

Drop NumPy 1.13 constraint

ac7c7a2

amueller and others added 3 commits July 24, 2017 11:04

pinning cython 0.25.2

5c44c49

rerender after pulling?

7eea17c

MNT: Re-rendered with conda-smithy 2.3.2.post.dev53

a049243

Re-render with a development copy of conda-smithy to add matrix support.

ogrisel approved these changes Jul 25, 2017

View reviewed changes

This was referenced Jul 31, 2017

Test 0.19.X branch #54

Closed

Test 0.19.X branch #55

Closed

lesteve closed this Sep 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build 0.19b2 #53

build 0.19b2 #53

amueller commented Jul 19, 2017

amueller commented Jul 19, 2017

jakirkham Jul 19, 2017

jakirkham commented Jul 19, 2017

amueller commented Jul 19, 2017

amueller commented Jul 19, 2017

jakirkham commented Jul 19, 2017

jakirkham commented Jul 19, 2017

amueller commented Jul 20, 2017

jakirkham commented Jul 20, 2017

amueller commented Jul 20, 2017

jakirkham commented Jul 20, 2017

jakirkham commented Jul 23, 2017

ogrisel commented Jul 24, 2017

jakirkham commented Jul 24, 2017

amueller commented Jul 24, 2017

jakirkham commented Jul 24, 2017

amueller commented Jul 24, 2017 via email

ogrisel commented Jul 25, 2017

build 0.19b2 #53

build 0.19b2 #53

Conversation

amueller commented Jul 19, 2017

amueller commented Jul 19, 2017

jakirkham Jul 19, 2017

Choose a reason for hiding this comment

jakirkham commented Jul 19, 2017

amueller commented Jul 19, 2017

amueller commented Jul 19, 2017

jakirkham commented Jul 19, 2017

jakirkham commented Jul 19, 2017

amueller commented Jul 20, 2017

jakirkham commented Jul 20, 2017

amueller commented Jul 20, 2017

jakirkham commented Jul 20, 2017

jakirkham commented Jul 23, 2017

ogrisel commented Jul 24, 2017

jakirkham commented Jul 24, 2017

amueller commented Jul 24, 2017

jakirkham commented Jul 24, 2017

amueller commented Jul 24, 2017 via email

ogrisel commented Jul 25, 2017